[PATCH] D143256: [SDAG] Check fminnum for non zero operand.
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 6 05:51:58 PST 2023
spatel added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:7980
+ auto IsConstantNonZero = [](SDValue N) {
+ if (auto *Input = dyn_cast<ConstantFPSDNode>(N))
----------------
spatel wrote:
> Is this different than
> auto *C = isConstOrConstSplatFP(N));
> return C && C->isZero();
>
Oops - invert that isZero() result (we're looking for non-zero constant).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143256/new/
https://reviews.llvm.org/D143256
More information about the llvm-commits
mailing list