[PATCH] D143106: [SDAG] fix miscompiles caused by using ValueTracking matchSelectPattern to create FMINIMUM/FMAXIMUM

Mikael Holmén via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 6 05:46:20 PST 2023


uabelho added a comment.

Hi,

Would the rewrite be legal if the fcmp was "fast" or would that also lead to miscompiles?
So e.g. if we have

  %cmp = fcmp fast ogt float %a, %b
  %cond = select i1 %cmp, float %a, float %b

?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143106/new/

https://reviews.llvm.org/D143106



More information about the llvm-commits mailing list