[PATCH] D140540: [MachineTraceMetrics] Add local strategy

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 6 05:10:08 PST 2023


spatel added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineTraceMetrics.cpp:321-322
 
+// LocalEnsemble - Pick only the current basic block for the trace and do not
+// choose any predecessors/successors.
+class LocalEnsemble : public MachineTraceMetrics::Ensemble {
----------------
I see that this is replicating the previous code comment, but we shouldn't repeat the class/variable/function name in the block comment, and it should probably use "///" to produce the expected doxygen output.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140540/new/

https://reviews.llvm.org/D140540



More information about the llvm-commits mailing list