[PATCH] D118563: [AARCH64][NEON] Reuse extended vdup value in low version of long operations when doing tryCombineLongOpWithDup

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 6 01:33:00 PST 2023


dmgreen added a comment.

Sorry for the delay. We tend not to iterate uses if we can avoid it.

Could we use DAG.getNodeIfExists to common the nodes that are both 64bit and 128bit, if both exist? Like the existing transform in performDUPCombine but for MOVI and DUPLANEs. That way might be a little more generic, where we might be able to handle more cases than just the umull too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118563/new/

https://reviews.llvm.org/D118563



More information about the llvm-commits mailing list