[PATCH] D142556: [DebugInfo] Merge partially matching chains of inlined locations

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

In D142556#4103178 <https://reviews.llvm.org/D142556#4103178>, @dblaikie wrote:

> Numbers look fairly good - wonder if you could get this run through the LLVM perf tracker to get some more stable/precise numbers?
> & any chance you could use something like bloaty ( https://github.com/google/bloaty ) or by hand comparison on a per-section basis on the clang binary? Getting a sense of, specifically, how much bigger this makes .debug_info (but any incidental changes to other sections too) might be helpful

I feel like mentioning “llvm-dwarfdump --show-section-sizes“ :)

In D142556#4105414 <https://reviews.llvm.org/D142556#4105414>, @dblaikie wrote:

> In D142556#4105194 <https://reviews.llvm.org/D142556#4105194>, @djtodoro wrote:
>
>> In D142556#4103178 <https://reviews.llvm.org/D142556#4103178>, @dblaikie wrote:
>>
>>> Numbers look fairly good - wonder if you could get this run through the LLVM perf tracker to get some more stable/precise numbers?
>>> & any chance you could use something like bloaty ( https://github.com/google/bloaty ) or by hand comparison on a per-section basis on the clang binary? Getting a sense of, specifically, how much bigger this makes .debug_info (but any incidental changes to other sections too) might be helpful
>>
>> I feel like mentioning “llvm-dwarfdump --show-section-sizes“ :)
>
> Indeed - I usually use `llvm-objdump -h` when I just want section sizes (it's useful to have the DWARF ones in the context of the others, even if sometimes I'm interested only in the change in DWARF sections). - but the think that I find especially useful about Bloaty is the comparison mode - showing per section % changes and overall % changes, etc.

(sorry for diverging from the topic of the patch:) ) I see. It will be really beneficial if we added something like that in our ```dwarffump```. I may find some free slots to implement that. Thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142556/new/

https://reviews.llvm.org/D142556