[PATCH] D143316: [m68k] Implement absolution long addressing mode for ADDA instruction

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu added inline comments.


================
Comment at: llvm/lib/Target/M68k/M68kInstrArithmetic.td:297
+  def NAME#"32ab" : MxBiArOp_R_RM<MN, NODE, MxType32a, MxType32.BOp, MxType32.BPat,
+                                  CMD, MxEncAddrMode_abs<"opd", 1>>;
   def NAME#"32ai" : MxBiArOp_R_RI_xEA<MN, NODE, MxType32a, CMD>;
----------------



================
Comment at: llvm/test/MC/M68k/Relocations/arith-abs.s:1
+; RUN: llvm-mc -triple m68k -filetype=obj %s -o - | \
+; RUN:          llvm-readobj -r - | FileCheck --check-prefix=RELOC %s
----------------
Can we put the test in `test/MC/M68k/Arith/Classes/MxBiArOp_RFRM.s` along with other ADDA tests? Also, I don't think it's necessary to test relocations in this patch since it's essentially covered by `test/MC/M68k/Relocations/data-abs.s` already.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143316/new/

https://reviews.llvm.org/D143316