[PATCH] D143353: [RISCV] Use OS-specific stack-guard ABI for Fuchsia

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/stack-protector-target.ll:11
+; FUCHSIA-RISCV64-NEXT:    addi sp, sp, -32
+; FUCHSIA-RISCV64-NEXT:    .cfi_def_cfa_offset 32
+; FUCHSIA-RISCV64-NEXT:    sd ra, 24(sp) # 8-byte Folded Spill
----------------
nounwind will clean these up


================
Comment at: llvm/test/CodeGen/RISCV/stack-protector-target.ll:28
+  %1 = alloca i32, align 4
+  call void @capture(ptr nonnull %1)
+  ret void
----------------
I guess while you're fixing the above you can drop the nonnull, it doesn't do anything useful here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143353/new/

https://reviews.llvm.org/D143353