[PATCH] D143353: [RISCV] Use OS-specific stack-guard ABI for Fuchsia

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 5 16:10:25 PST 2023


phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.h:166
 
+  /// TargetTriple - What processor and OS we're targeting.
+  Triple TargetTriple;
----------------
Nit: We usually don't repeat the name of the field in the documentation comment (`AArch64Subtarget.h` does that but it's not common across LLVM).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143353/new/

https://reviews.llvm.org/D143353



More information about the llvm-commits mailing list