[PATCH] D142443: [ORC] Drop Comdat when discarding IR symbol

Jonas Hahnfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 5 01:58:50 PST 2023


Hahnfeld added a comment.

In D142443#4104625 <https://reviews.llvm.org/D142443#4104625>, @lhames wrote:

> In D142443#4104430 <https://reviews.llvm.org/D142443#4104430>, @Hahnfeld wrote:
>
>> I received three complaints from AArch64 bots now failing Clang Interpreter tests, for example: https://lab.llvm.org/buildbot/#/builders/197/builds/3920 I don't quite understand how this can happen and currently have no easy way to verify, so reverting a second time...
>
> That looks like the issue that's being discussed in https://reviews.llvm.org/D143039. If so then it's unrelated to your patch.

Yes, I noticed shortly after my revert that the tests had actually turned green again after 5b2549b0d2834a653be60b52885bdc9f21abc2ee <https://reviews.llvm.org/rG5b2549b0d2834a653be60b52885bdc9f21abc2ee>. I will push shortly, folding in your change to `UNSUPPORTED`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142443/new/

https://reviews.llvm.org/D142443



More information about the llvm-commits mailing list