[PATCH] D143039: [AArch64] Unconditionally use DW_EH_PE_indirect|DW_EH_PE_pcrel personality/lsda/ttype encodings

Sat Feb 4 18:18:51 PST 2023

lhames added a comment.

In D143039#4104425 <https://reviews.llvm.org/D143039#4104425>, @MaskRay wrote:

> In D143039#4104375 <https://reviews.llvm.org/D143039#4104375>, @lhames wrote:
>
>> My best guess is that the JIT linker is dropping this. I'm just doing a Linux build now so that I can figure out what's going wrong.
>
> I suspect that 43acef48d38ec0dd391f212144d4a25095e4fc5f <https://reviews.llvm.org/rG43acef48d38ec0dd391f212144d4a25095e4fc5f> has incomplete support.

I'm not sure that the linker needs to do anything with `DW_EH_PE_indirect`, does it? libunwind to know to do one more level of pointer chasing, but from the linker's point it's irrelevant.

Looks like the root cause is that we're not using JITLink at all -- on Linux/aarch64 we still default to using RuntimeDyld, and that's fumbling the weak symbol somehow. I'm going to try switching LLJIT's default for Linux/aarch64 to JITLink -- it's about time we did that anyway.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143039/new/

https://reviews.llvm.org/D143039