[PATCH] D139752: cmake: Enable 64bit off_t on 32bit glibc systems

[Michał Górny via Phabricator via llvm-commits]

mgorny added a comment.

I haven't been able to get Halide to configure successfully yet but I already spotted something suspicious. `dependencies/llvm/CMakeLists.txt` does:

  set(Halide_LLVM_DEFS ${LLVM_DEFINITIONS} $<BUILD_INTERFACE:LLVM_VERSION=${LLVM_VERSION_MAJOR}${LLVM_VERSION_MINOR}>)

then:

  list(APPEND Halide_LLVM_DEFS $<BUILD_INTERFACE:${DEFINE}>)

So `Halide_LLVM_DEFS` becomes a weird mix of semicolon separated entries with space separated entries inside:

  -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
  -D_FILE_OFFSET_BITS=64 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS
  -D__STDC_LIMIT_MACROS;$<BUILD_INTERFACE:LLVM_VERSION=170>;$<BUILD_INTERFACE:WITH_AARCH64>;$<BUILD_INTERFACE:WITH_AMDGPU>;$<BUILD_INTERFACE:WITH_ARM>;$<BUILD_INTERFACE:WITH_HEXAGON>;$<BUILD_INTERFACE:WITH_NVPTX>;$<BUILD_INTERFACE:WITH_POWERPC>;$<BUILD_INTERFACE:WITH_RISCV>;$<BUILD_INTERFACE:WITH_X86>

My suggestion would be to start by trying to replace spaces with semicolons there, so it's a proper list and see if that helps, i.e. after the first set:

  string(REPLACE " " ";" Halide_LLVM_DEFS ${Halide_LLVM_DEFS})


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139752/new/

https://reviews.llvm.org/D139752