[PATCH] D143226: [MC][CodeGen] Introduce handling for R_RISCV_PLT32 relocation

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.

> This introduces R_RISCV_PLT32, a pc-relative relocation that takes the offset to a function (or its plt entry) from the reloc's location.

My suggested wording on the PR uses proper cases: `PC-relative` and `PLT`, and `relocation location`.



================
Comment at: llvm/test/CodeGen/RISCV/dso_local_equivalent.ll:6
+; CHECK-LABEL: const:
+; CHECK:         .word   extern_func at PLT-const
+
----------------
You can add `{{$}}` to the end to prevent such a mistake or switch to `FileCheck --match-full-lines`


================
Comment at: llvm/test/CodeGen/RISCV/dso_local_equivalent.ll:1
+; RUN: llc -mtriple=riscv64 -relocation-model=pic -data-sections -o - %s --asm-verbose=0 | FileCheck %s
+
----------------
jrtc27 wrote:
> Use update_llc_test_checks.py
I think it is fine not using update_llc_test_checks.py. The test clearly doesn't cause more maintenance trouble.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143226/new/

https://reviews.llvm.org/D143226