[PATCH] D143293: AMDGPU: Use module flag to get code object version at IR level folow-up

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 3 15:06:30 PST 2023


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp:807
       break;
-    case ELF::ELFABIVERSION_AMDGPU_HSA_V4:
-    case ELF::ELFABIVERSION_AMDGPU_HSA_V5:
+    case 4:
+    case 5:
----------------
Going from enum names to magic constants is a regression 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143293/new/

https://reviews.llvm.org/D143293



More information about the llvm-commits mailing list