[PATCH] D143229: [FunctionImporter] Don't upgrade debug info if llvm.idents match

Fri Feb 3 14:53:14 PST 2023

steven_wu added a comment.

In D143229#4103367 <https://reviews.llvm.org/D143229#4103367>, @aeubanks wrote:

> In D143229#4103364 <https://reviews.llvm.org/D143229#4103364>, @steven_wu wrote:
>
>> In D143229#4103332 <https://reviews.llvm.org/D143229#4103332>, @aeubanks wrote:
>>
>>> check llvm.ident instead
>>
>> If my source module is bitcode upgraded, it won't get a new `llvm.ident` right? Then the upgrade pass will be wrongly skipped. I think we need a LLVM code generator version somewhere in the IR
>
> it the bitcode was upgraded, then during the upgrade it should already have had `UpgradeDebugInfo` called on it (with the expected LLVM revision) right?

I am talking about A.bc imports function from B.bc. Both of bitcode files are out of date, so A.bc gets upgraded when loaded, then A tries to import B, they have the same ident so the upgrade from B is skipped.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143229/new/

https://reviews.llvm.org/D143229