[PATCH] D139902: IR: Add nofpclass parameter attribute

[Joshua Cranmer via Phabricator via llvm-commits]

jcranmer-intel added inline comments.


================
Comment at: llvm/lib/AsmParser/LLParser.cpp:2430-2432
+
+  tokError("unterminated nofpclass attribute");
+  return 0;
----------------
If I'm not mistaken, these lines are unreachable?


================
Comment at: llvm/test/Assembler/nofpclass.ll:103
+}
+
+; --------------------------------------------------------------------
----------------
A test with a hex nofpclass parameter would also be useful, given that you use that as one of the examples in the langref.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139902/new/

https://reviews.llvm.org/D139902