[PATCH] D143229: [FunctionImporter] Don't upgrade debug info for ThinLTO compiles

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks updated this revision to Diff 494708.
aeubanks added a comment.

check llvm.ident instead


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143229/new/

https://reviews.llvm.org/D143229

Files:
  llvm/lib/Transforms/IPO/FunctionImport.cpp
  llvm/test/LTO/X86/Inputs/strip-debug-info-bar-ident.ll
  llvm/test/LTO/X86/strip-debug-info.ll


Index: llvm/test/LTO/X86/strip-debug-info.ll
===================================================================
--- llvm/test/LTO/X86/strip-debug-info.ll
+++ llvm/test/LTO/X86/strip-debug-info.ll
@@ -13,6 +13,8 @@
 ; RUN: opt -disable-verify -disable-upgrade-debug-info -module-summary %s -o %t.bc
 ; RUN: opt -disable-verify -disable-upgrade-debug-info -module-summary %S/Inputs/strip-debug-info-bar.ll \
 ; RUN:     -o %t2.bc
+; RUN: opt -disable-verify -disable-upgrade-debug-info -module-summary %S/Inputs/strip-debug-info-bar-ident.ll \
+; RUN:     -o %t3.bc
 ; RUN: llvm-lto -thinlto -thinlto-action=run \
 ; RUN:     %t.bc -disable-verify 2>&1 | \
 ; RUN:     FileCheck %s -allow-empty -check-prefix=CHECK-WARN
@@ -24,10 +26,18 @@
 ; RUN:     -exported-symbol foo -exported-symbol _foo \
 ; RUN:     %t-stripped.bc -disable-verify 2>&1 | \
 ; RUN:     FileCheck %s -allow-empty -check-prefix=CHECK-WARN
+; ---- Thin LTO (optimize, don't strip imported file due to matching llvm.ident)
+; RUN: llvm-lto -thinlto-action=thinlink -o %t.index.bc %t-stripped.bc %t3.bc
+; RUN: llvm-lto -thinlto -thinlto-action=import \
+; RUN:     -thinlto-index=%t.index.bc \
+; RUN:     -exported-symbol foo -exported-symbol _foo \
+; RUN:     %t-stripped.bc -disable-verify 2>&1 | \
+; RUN:     FileCheck %s -allow-empty -check-prefix=CHECK-NO-WARN
 
 ; CHECK-WARN: warning{{.*}} ignoring invalid debug info
 ; CHECK-WARN-NOT: Broken module found
 ; CHECK: foo
+; CHECK-NO-WARN-NOT: ignoring invalid debug info
 target datalayout = "e-m:o-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
 target triple = "x86_64-apple-macosx10.12"
 
@@ -40,6 +50,8 @@
 
 !llvm.module.flags = !{!0}
 !llvm.dbg.cu = !{!1}
+!llvm.ident = !{!2}
 
 !0 = !{i32 2, !"Debug Info Version", i32 3}
 !1 = !DIFile(filename: "broken", directory: "")
+!2 = !{!"version 42"}
Index: llvm/test/LTO/X86/Inputs/strip-debug-info-bar-ident.ll
===================================================================
--- /dev/null
+++ llvm/test/LTO/X86/Inputs/strip-debug-info-bar-ident.ll
@@ -0,0 +1,16 @@
+target datalayout = "e-m:o-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-apple-macosx10.12"
+
+define void @bar() !dbg !3 {
+  ret void
+}
+
+!llvm.module.flags = !{!0}
+!llvm.dbg.cu = !{!1}
+!llvm.ident = !{!4}
+
+!0 = !{i32 2, !"Debug Info Version", i32 3}
+!1 = distinct !DICompileUnit(language: DW_LANG_C99, file: !2)
+!2 = !DIFile(filename: "broken", directory: "")
+!3 = distinct !DISubprogram(line: 1000, isDefinition: true)
+!4 = !{!"version 42"}
Index: llvm/lib/Transforms/IPO/FunctionImport.cpp
===================================================================
--- llvm/lib/Transforms/IPO/FunctionImport.cpp
+++ llvm/lib/Transforms/IPO/FunctionImport.cpp
@@ -1349,9 +1349,16 @@
       }
     }
 
+    // Skip upgrading debug info if the producer versions of both modules match.
+    bool ShouldUpgradeDebugInfo = true;
+    if (NamedMDNode *SrcMD = SrcModule->getNamedMetadata("llvm.ident"))
+      if (NamedMDNode *DestMD = DestModule.getNamedMetadata("llvm.ident"))
+        ShouldUpgradeDebugInfo = SrcMD->getName() != DestMD->getName();
+
     // Upgrade debug info after we're done materializing all the globals and we
     // have loaded all the required metadata!
-    UpgradeDebugInfo(*SrcModule);
+    if (ShouldUpgradeDebugInfo)
+      UpgradeDebugInfo(*SrcModule);
 
     // Set the partial sample profile ratio in the profile summary module flag
     // of the imported source module, if applicable, so that the profile summary


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143229.494708.patch
Type: text/x-patch
Size: 3569 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230203/eb35f89e/attachment.bin>