[PATCH] D142443: [ORC] Drop Comdat when discarding IR symbol

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 3 12:05:16 PST 2023


lhames added a comment.

In D142443#4103013 <https://reviews.llvm.org/D142443#4103013>, @thakis wrote:

> Instead of adding an xfail, does it make more sense to pass an explicit triple to lli instead?

I think `UNSUPPORTED` is the right way to go here. I've made that change in `7e528d4689e6`.

Belatedly -- this change looks good to me. Thanks @Hahnfeld!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142443/new/

https://reviews.llvm.org/D142443



More information about the llvm-commits mailing list