[PATCH] D143269: [DWARFLinker] Refactor cloneAddressAttribute().

[Frederic Riss via Phabricator via llvm-commits]

friss added a comment.

This feels like a nice generalization (and I like the shape of the new code better), but I'm wondering if it's not too general. For example a `DT_AT_location` can be `DW_FORM_addr`, and applying PCOffset to it would be wrong. I'm not sure what PCOffset is set to in a variable DIE, but it does feel somewhat wrong even if it's 0. I cannot be 100% sure, but I believe that fear of mishandling non-PC addresses was the original thinking that led to spelling out all the supported cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143269/new/

https://reviews.llvm.org/D143269