[PATCH] D143039: [AArch64] Unconditionally use DW_EH_PE_indirect|DW_EH_PE_pcrel personality/lsda/ttype encodings

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 3 09:59:13 PST 2023


MaskRay added a comment.

In D143039#4102919 <https://reviews.llvm.org/D143039#4102919>, @peter.smith wrote:

> The Code Models https://github.com/ARM-software/abi-aa/blob/main/sysvabi64/sysvabi64.rst#7code-models do clarify that the text segment includes ro-data explicitly for the benefit of signed 32-bit offsets, however I don't think that this should change the decision here to use sdata8 for AArch64 targets. So no objections from me.

Thanks. Perhaps a better interpretation is that it is unnecessary to make `-fno-pic -mcmodel={tiny,small}` different. The scenarios that uses both `-fno-pic` and C++ exceptions have been increasingly rare now, so there is not many advantage optimizing for the little size saving here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143039/new/

https://reviews.llvm.org/D143039



More information about the llvm-commits mailing list