[PATCH] D142983: Add build for Windows on Arm in packaging script

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 3 09:48:43 PST 2023


hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

lgtm

In D142983#4101865 <https://reviews.llvm.org/D142983#4101865>, @pbo-linaro wrote:

> After discussion with @omjavaid, we decided to build same list of projects for arm64, than x64/x86.
>
> The flang/mlir support could be added later with another patch.
> Does this seem good to you @hans ?

Sounds good to me.



================
Comment at: llvm/utils/release/build_llvm_release.bat:308
+ninja || exit /b 1
+::ninja check-llvm || exit /b 1
+::ninja check-clang || exit /b 1
----------------
What's the state of these tests on win/arm64? Should we enable some in a follow-up patch?


================
Comment at: llvm/utils/release/build_llvm_release.bat:334
+REM Check but do not fail on errors.
+ninja check-lldb
+::ninja check-llvm || exit /b 1
----------------
With all the other tests commented out, I'm surprised these are running.. do they pass? Should they be commented out too for now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142983/new/

https://reviews.llvm.org/D142983



More information about the llvm-commits mailing list