[PATCH] D143256: [SDAG] Check fminnum for non zero operand.

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 3 07:49:02 PST 2023


spatel added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:7995
+  // instead if there are no NaNs and at least one operand isn't +/-0.
+  if (Node->getFlags().hasNoNaNs() &&
+      (IsConstantNonZero(Node->getOperand(0)) ||
----------------
Could we also check hasNoSignedZeros() and allow this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143256/new/

https://reviews.llvm.org/D143256



More information about the llvm-commits mailing list