[PATCH] D142953: [RISCV] Don't use constantpool for floating-point value if the value can be easily constructed by integer sequence and a floating-point move.
Philip Reames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 3 07:41:47 PST 2023
reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.
LGTM, but please wait a day or two before landing in case @craig.topper has comments. I still don't consider myself to fully understand the ISEL interactions. I *think* this is good to go, but probably good to have him double check.
================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1471
+ }
+ // Special case: the cost for -0.0 is 1.
+ int Cost = Imm.isNegZero()
----------------
Doing the -0.0 case as an early return check would likely be clearer here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142953/new/
https://reviews.llvm.org/D142953
More information about the llvm-commits
mailing list