[PATCH] D142443: [ORC] Drop Comdat when discarding IR symbol

Fri Feb 3 07:24:44 PST 2023

spatel added a comment.

In D142443#4102581 <https://reviews.llvm.org/D142443#4102581>, @Hahnfeld wrote:

> In D142443#4102559 <https://reviews.llvm.org/D142443#4102559>, @spatel wrote:
>
>> In D142443#4102519 <https://reviews.llvm.org/D142443#4102519>, @Hahnfeld wrote:
>>
>>> In D142443#4102513 <https://reviews.llvm.org/D142443#4102513>, @spatel wrote:
>>>
>>>> The test seems to be crashing on macOS with or without the code change:
>>>> "LLVM ERROR: MachO doesn't support COMDATs, 'f' cannot be lowered."
>>>
>>> Hm right... If you are on macOS, could you test if `XFAIL: target={{.*}}-darwin{{.*}}` correctly excludes the test?
>>
>> Still crashing after I add that line - let me know if I'm missing anything:
>
> Yeah sorry, I added an additional dash after `darwin` in my initial comment. Can you try removing that?

Yes - that works; no more crash report.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142443/new/

https://reviews.llvm.org/D142443