[PATCH] D143097: [NFC] add new function is64Bit for SymbolicFile class
Digger Lin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 3 06:03:28 PST 2023
DiggerLin marked 4 inline comments as done.
DiggerLin added inline comments.
================
Comment at: llvm/include/llvm/Object/MachO.h:740
StringRef getStringTableData() const;
- bool is64Bit() const;
+
void ReadULEB128s(uint64_t Index, SmallVectorImpl<uint64_t> &Out) const;
----------------
jhenderson wrote:
> I'm not sure there's a need to move the declaration?
just move the all the override API together.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143097/new/
https://reviews.llvm.org/D143097
More information about the llvm-commits
mailing list