[PATCH] D143235: [AArch64] Avoid lowering setjmp call to CALL_BTI if harden-sls-blr is enabled

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 3 03:31:20 PST 2023


DavidSpickett requested changes to this revision.
DavidSpickett added a comment.
This revision now requires changes to proceed.

This change would lead to a situation where you have sls-blr and bti enabled but you don't get a bti after the setjmp call, which is going to be a hard failure once you return from the setjmp.

Talking to Kristof, we don't think there's any reason that CALL_BTI can't coexist with the sls mitigation. This could be done by following what `AArch64call` does https://github.com/llvm/llvm-project/blob/6e1ebb916e467f26d3c0cb0819770cd67f956cc3/llvm/lib/Target/AArch64/AArch64InstrInfo.td#L2567.

Since this was my change originally, I will work on a patch to do that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143235/new/

https://reviews.llvm.org/D143235



More information about the llvm-commits mailing list