[PATCH] D142746: AMDGPU: Fold fneg into bitcast of build_vector

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 3 03:21:12 PST 2023


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp:4133
+    SDValue BCSrc = N0.getOperand(0);
+    if (BCSrc.getOpcode() == ISD::BUILD_VECTOR) {
+      SDValue HighBits = BCSrc.getOperand(BCSrc.getNumOperands() - 1);
----------------
Pierre-vh wrote:
> Do a early return instead to reduce indentation?
That would just get re-indented in the next patch 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142746/new/

https://reviews.llvm.org/D142746



More information about the llvm-commits mailing list