[PATCH] D143073: [DebugInfo] Handle fixed-width DW_FORM_addrx variants in DWARFFormValue::getAsSectionedAddress()

[Benjamin Maxwell via Phabricator via llvm-commits]

benmxwl-arm updated this revision to Diff 494579.
benmxwl-arm added a comment.

I've updated DWARFFormValue::dump() to make use of getAsSectionedAddress(), which slightly simplifies it.

I've now also added some unit tests for the DWARF5 indexed address forms to DWARFDebugInfoTest. 
Previously, this was only testing the non-indexed addresses in TestAllForms().

To do this I had to add support for the indexed addresses in the unittest DwarfGenerator, so
please let me know if that looks correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143073/new/

https://reviews.llvm.org/D143073

Files:
  llvm/lib/DebugInfo/DWARF/DWARFFormValue.cpp
  llvm/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp
  llvm/unittests/DebugInfo/DWARF/DwarfGenerator.cpp
  llvm/unittests/DebugInfo/DWARF/DwarfGenerator.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143073.494579.patch
Type: text/x-patch
Size: 10427 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230203/b55cd08b/attachment.bin>