[PATCH] D143120: [llvm] infer rtlib from triple for codegen decisions

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: llvm/include/llvm/TargetParser/Triple.h:296
+    LIB_GCC,
+    WINDOWS_RT,
+  };
----------------
mstorsjo wrote:
> Some comments on the naming here...
> 
> There's really nothing like `WINDOWS_RT` - the OS itself doesn't have anything corresponding to it, but it's all a toolchain specific library - I think the most correct name for it right now would be `VCRUNTIME`.
> 
> Also as a nitpick/personal opinion, spelling it `LIB_GCC` feels weird to me, I'd just spell it `LIBGCC`.
Another suggestion on the naming... we don't use `ALL_CAPS` for other enum values unless they're acronyms, so `CompilerRT`, `Libgcc` and `VCRuntime` would be more in line with the existing values.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143120/new/

https://reviews.llvm.org/D143120