[PATCH] D141460: [bootstrap build] Add libc-hdrgen as a build dep for libc bootstrap build.

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: llvm/runtimes/CMakeLists.txt:382-383
   endif()
+  set(libc_tools)
+  set(libc_cmake_args)
+  if("libc" IN_LIST LLVM_ENABLE_RUNTIMES AND LLVM_LIBC_FULL_BUILD)
----------------
Nit: this is unnecessary (uninitialized variables in CMake evaluate to empty string).


================
Comment at: llvm/runtimes/CMakeLists.txt:391-392
+    else()
+      # We want to build the libc build tools before we can build the libc
+      # itself. So, the libc project should be included in LLVM_ENABLE_PROJECTS.
+      message(FATAL_ERROR
----------------
This is slightly counterintuitive. I'd prefer introducing a special handling in `llvm/CMakeLists.txt` similarly to what we do for example for `flang` and `mlir`, see https://github.com/llvm/llvm-project/blob/830d116d776439093a16aad567cd3db2c4c3cd72/llvm/CMakeLists.txt#L143 and automatically including `libc` in `LLVM_ENABLE_PROJECTS` when `libc` is in `LLVM_ENABLE_RUNTIMES`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141460/new/

https://reviews.llvm.org/D141460