[PATCH] D142983: Add build for Windows on Arm in packaging script

Fri Feb 3 00:31:02 PST 2023

omjavaid added inline comments.

================
Comment at: llvm/utils/release/build_llvm_release.bat:329
+  -DCPACK_SYSTEM_NAME=woa64 ^
+  -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra;flang;lld;lldb;compiler-rt;mlir"
+set cmake_flags=%all_cmake_flags:\=/%
----------------
hans wrote:
> omjavaid wrote:
> > hans wrote:
> > > ..and mlir?
> > > 
> > > I wonder if we should try to keep LLVM_ENABLE_PROJECTS the same across targets, maybe there could be a flag to add flang to it if we need that.
> > mlir + flang included to woa build since 14.0.0. IMO should be added to x64 as well.
> What does including mlir even mean since we build with -DLLVM_INSTALL_TOOLCHAIN_ONLY=ON? I thought it was a library?
> 
> As for flang, I'd suggest adding it behind a flag for now, which controls whether it gets added to ENABLE_PROJECTS centrally. You could default the flag to on for arm64 I suppose since it's been shipping there already.
Agreed. We only need clang at stage0 and for stage1 only arm64 can have mlir+flang. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142983/new/

https://reviews.llvm.org/D142983