[PATCH] D140135: AMDGPU: Try to unfold fneg source when matching legacy fmin/fmax

[Matt Arsenault via Phabricator via llvm-commits]

arsenm closed this revision.
arsenm added a comment.

36cfe26a5288d99e66c75d82989d154874999b98



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp:1401
+}
+SDValue AMDGPUTargetLowering::combineFMinMaxLegacyImpl(
+    const SDLoc &DL, EVT VT, SDValue LHS, SDValue RHS, SDValue True,
----------------
foad wrote:
> This function doesn't use False. Might be clearer to take a Swapped flag instead of True and False.
I think it's harder to read if you're considering the caller context


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140135/new/

https://reviews.llvm.org/D140135