[PATCH] D143225: [SROA] Create additional vector type candidates based on store and load slices

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/SROA.cpp:1960
+  for (Type *Ty : LoadStoreTys) {
+    if (isa<VectorType>(Ty) || !VectorType::isValidElementType(Ty))
+      continue;
----------------
The first isa<VectorType> should be redundant with the isValidElementType check


================
Comment at: llvm/test/Transforms/SROA/vector-promotion.ll:645
+}
+
 define void @swap-8bytes(ptr %x, ptr %y) {
----------------
Should add some vector of pointer tests 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143225/new/

https://reviews.llvm.org/D143225