[PATCH] D143115: [lld][RISCV] Introduce handling for R_RISCV_PLT32 relocation

Leonard Chan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 15:52:48 PST 2023


leonardchan added a comment.

Split the patches in two: D143226 <https://reviews.llvm.org/D143226> has the llvm parts



================
Comment at: lld/test/ELF/riscv-undefined-weak.s:89
+.word target at plt - .
+# RELOC:      0xC R_RISCV_PLT32 target 0x0
----------------
jrtc27 wrote:
> MaskRay wrote:
> > Place the CHECK line above the instruction (the style used in this test file).
> This also needs a HEX, otherwise you're not testing the linker at all here.
Uhh. Added one, but checking the actual hex dynamically is a bit difficult in lit. I can get individual addresses from objdump then do arithmetic in lit, but don't know a way to flip the result to match the endianness of objdump's output, so I hope the comments in the updated patch explain well enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143115/new/

https://reviews.llvm.org/D143115



More information about the llvm-commits mailing list