[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly
Philip Reames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 2 14:26:49 PST 2023
reames added a comment.
This was brought up in today's RISCV sync call; I want to summarize the major points of discussion.
This patch is now behind the current most recent revision on the vector-crypto spec. (https://github.com/riscv/riscv-crypto/releases/download/v20230125/riscv-crypto-spec-vector.pdf) The assumption is that the patch needs to be updated to match most recent. If there's a reason why this assumption is wrong, please explicitly describe the argument.
There was confusion around the versioning scheme used in the vector-crypto spec. It looks like newer version have moved to an internally consistent (and less than 1.0) version scheme, so I think this item is resolved.
There was a mention of another change being made to the spec in the near future and a desire to wait until that had happened. This isn't required by our experimental extension policy. However, in generally trying to minimize churn by delaying a couple days is not unreasonable. I'd welcome comment from someone following spec changes as to whether we should delay here or not, and why.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141672/new/
https://reviews.llvm.org/D141672
More information about the llvm-commits
mailing list