[PATCH] D143107: [SPIR-V] Emit spv_undef intrinsic for aggregate undef operands
Ilia Diachkov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 2 13:36:12 PST 2023
iliya-diyachkov added inline comments.
================
Comment at: llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp:155
+void SPIRVEmitIntrinsics::preprocessUndefs() {
+ std::queue<Instruction *> Worklist;
----------------
arsenm wrote:
> I don't really understand why you need to handle this in an IR pass, undoes could easily appear at any time
@arsenm This is required just before IRTranslator to pass aggregate undefs through it. Undefs appearing in other places are already supported.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143107/new/
https://reviews.llvm.org/D143107
More information about the llvm-commits
mailing list