[PATCH] D143138: AMDGPU: Use module flag to get code object version at IR level

Changpeng Fang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 11:47:48 PST 2023


cfang added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:414
     bool SupportsGetDoorbellID = InfoCache.supportsGetDoorbellID(*F);
+    unsigned COV = AMDGPU::getCodeObjectVersion(*F->getParent());
 
----------------
arsenm wrote:
> Cann move this into AMDGPUInformationCache
Should we introduce a private field of Module *M in AMDGPUInformationCache? 
InformationCache itself does not have this field.
Otherwise, we will have to pass a Module parameter in the call to check code object version each time.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143138/new/

https://reviews.llvm.org/D143138



More information about the llvm-commits mailing list