[PATCH] D142191: [lld][RISCV] Merge subtarget features to get right attributes section

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 11:15:54 PST 2023


MaskRay requested changes to this revision.
MaskRay added a comment.

I agree with @jrtc27 that this patch is fundamentally flawed. A function may get different attributes (usually extra ones) from the module due to Function Multi Versioning features (GNU function attributes target/target_version/target_clones).
These functions are dispatched at run-time. It is not correct to assume that the mere presence of a function with extra attributes changes the requirement of the module.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142191/new/

https://reviews.llvm.org/D142191



More information about the llvm-commits mailing list