[llvm] 6d9e7fa - [LLVM][Runtimes] Hide unused CMake variable messages for runtimes builds

Joseph Huber via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 10:54:51 PST 2023


Author: Joseph Huber
Date: 2023-02-02T12:54:43-06:00
New Revision: 6d9e7fa1de603451cd33911fb8754205219345d8

URL: https://github.com/llvm/llvm-project/commit/6d9e7fa1de603451cd33911fb8754205219345d8
DIFF: https://github.com/llvm/llvm-project/commit/6d9e7fa1de603451cd33911fb8754205219345d8.diff

LOG: [LLVM][Runtimes] Hide unused CMake variable messages for runtimes builds

The LLVM runtime build is used to bootstrap projects with the built LLVM
toolchain. This effectively re-runs CMake with the current build
directory. One problem is that this passes every common CMake variable
to the projects individually, some of which are not necessarily used.

This patch suppresses the unused variable warnings for the runtimes.
The standard CMake invocation should still be able to print out the
unused variables so it should not impact code quality.

Reviewed By: thieta

Differential Revision: https://reviews.llvm.org/D143199

Added: 
    

Modified: 
    llvm/cmake/modules/LLVMExternalProjectUtils.cmake

Removed: 
    


################################################################################
diff  --git a/llvm/cmake/modules/LLVMExternalProjectUtils.cmake b/llvm/cmake/modules/LLVMExternalProjectUtils.cmake
index 120462b57466e..cc2eefb5d6122 100644
--- a/llvm/cmake/modules/LLVMExternalProjectUtils.cmake
+++ b/llvm/cmake/modules/LLVMExternalProjectUtils.cmake
@@ -302,6 +302,7 @@ function(llvm_ExternalProject_Add name source_dir)
     BINARY_DIR ${BINARY_DIR}
     ${exclude}
     CMAKE_ARGS ${${nameCanon}_CMAKE_ARGS}
+               --no-warn-unused-cli
                ${compiler_args}
                -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}
                ${sysroot_arg}


        


More information about the llvm-commits mailing list