[PATCH] D143199: [LLVM][Runtimes] Hide unused CMake variable messages for runtimes builds

Joseph Huber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 09:37:58 PST 2023


jhuber6 created this revision.
jhuber6 added reviewers: phosek, tianshilei1992, aaron.ballman, MaskRay, ye-luo, thieta.
Herald added a project: All.
jhuber6 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The LLVM runtime build is used to bootstrap projects with the built LLVM
toolchain. This effectively re-runs CMake with the current build
directory. One problem is that this passes every common CMake variable
to the projects individually, some of which are not necessarily used.

This patch suppresses the unused variable warnings for the runtimes.
The standard CMake invocation should still be able to print out the
unused variables so it should not impact code quality.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D143199

Files:
  llvm/cmake/modules/LLVMExternalProjectUtils.cmake


Index: llvm/cmake/modules/LLVMExternalProjectUtils.cmake
===================================================================
--- llvm/cmake/modules/LLVMExternalProjectUtils.cmake
+++ llvm/cmake/modules/LLVMExternalProjectUtils.cmake
@@ -302,6 +302,7 @@
     BINARY_DIR ${BINARY_DIR}
     ${exclude}
     CMAKE_ARGS ${${nameCanon}_CMAKE_ARGS}
+               --no-warn-unused-cli 
                ${compiler_args}
                -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}
                ${sysroot_arg}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143199.494343.patch
Type: text/x-patch
Size: 507 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230202/59d7f66a/attachment.bin>


More information about the llvm-commits mailing list