[PATCH] D142482: [Codegen] Support symmetric operations on complex numbers

Nicholas Guy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 06:36:52 PST 2023


NickGuy updated this revision to Diff 494287.
NickGuy retitled this revision from "[Codegen][ARM][AArch64] Support symmetric operations on complex numbers" to "[Codegen] Support symmetric operations on complex numbers".
NickGuy added a comment.

Split out unrelated changes, added more tests, unified the common logic, and renamed `Passthrough` to `Symmetric`.

> This checks various conditions about the operation, then checks for exact opcodes below, none of which will throw of have side effects. The switch table should be enough.

It was an initial attempt to try and be clever, removed.

> I may be missing it, but what checks that the two operations are the same?

You're not missing anything, it existed at one point, but it got removed in one of the iterations. I've readded it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142482/new/

https://reviews.llvm.org/D142482

Files:
  llvm/include/llvm/CodeGen/ComplexDeinterleavingPass.h
  llvm/lib/CodeGen/ComplexDeinterleavingPass.cpp
  llvm/test/CodeGen/AArch64/complex-deinterleaving-mixed-cases.ll
  llvm/test/CodeGen/Thumb2/mve-complex-deinterleaving-mixed-cases.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142482.494287.patch
Type: text/x-patch
Size: 18294 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230202/7589e4f7/attachment.bin>


More information about the llvm-commits mailing list