[PATCH] D143171: [NFC] PHITransAddr refactoring

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev requested changes to this revision.
mkazantsev added a comment.
This revision now requires changes to proceed.

I'm generally fine with the whole thing, but I'm against merging several unrelated change sets into one patch. They should be at least somehow related by thematics.

Be merciful to the reviewers, such a salad makes eyes bleed. :(

Please separate them, like:

- A patch that changes API of translateValue;
- A patch that changes loops with counters into standard;
- A patch that removes isSafeToSpeculativelyExecute

I'm sure that separately none of them will cause any trouble. I'm just asking to make it edible for review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143171/new/

https://reviews.llvm.org/D143171