[PATCH] D138202: [OHOS] Add support for OpenHarmony

[David Spickett via Phabricator via llvm-commits]

DavidSpickett added a reviewer: DavidSpickett.
DavidSpickett added inline comments.


================
Comment at: llvm/test/Transforms/SafeStack/AArch64/abi.ll:7
 entry:
+; OHOS-NOT: call i8* @llvm.thread.pointer()
 ; CHECK: %[[TP:.*]] = call i8* @llvm.thread.pointer()
----------------
This should have a comment if there is some OpenHarmony specific behaviour here.


================
Comment at: llvm/test/Transforms/SafeStack/AArch64/unreachable.ll:6
 entry:
+; OHOSMUSL-NOT: call i8* @llvm.thread.pointer()
 ; CHECK: %[[TP:.*]] = call i8* @llvm.thread.pointer()
----------------
arsenm wrote:
> New tests should use opaque pointers (has this one somehow missed conversion?)
Same here please note why OpenHarmony needs this specific check. Also note that `FileCheck %s --check-prefix=OHOSMUSL` will only check that prefix, not that plus the CHECK. I don't know if that is what you intended.




================
Comment at: llvm/unittests/ADT/TripleTest.cpp:813
+
+  T = Triple("arm-unknown-liteos");
+  EXPECT_EQ(Triple::arm, T.getArch());
----------------
Is the "canonical" triple here `arm-unknown-liteos-ohos` ? I guess you are testing here to make sure that `liteos` implies `ohos` if `ohos` is not in the triple already.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138202/new/

https://reviews.llvm.org/D138202