[PATCH] D118250: AMDGPU: Mark control flow intrinsics non-duplicable

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.

LGTM with additional comments



================
Comment at: llvm/lib/Target/AMDGPU/SIInstructions.td:427
   let hasSideEffects = 1;
+  let isNotDuplicable = 1;
   let mayLoad = 1; // FIXME: Should not need memory flags
----------------
Should add a comment that this is not a hard requirement


================
Comment at: llvm/lib/Target/AMDGPU/SIInstructions.td:435
   let Size = 4;
+  let isNotDuplicable = 1;
   let isAsCheapAsAMove = 1;
----------------
Should add a comment that this is not a hard requirement


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118250/new/

https://reviews.llvm.org/D118250