[PATCH] D142224: [Support] Emulate SIGPIPE handling in raw_fd_ostream write for Windows

[Andrew Ng via Phabricator via llvm-commits]

andrewng added a comment.

In D142224#4097372 <https://reviews.llvm.org/D142224#4097372>, @aganea wrote:

> You'd probably need to remove this #define: https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/Driver.cpp#L1876

Thanks for spotting this.

In D142224#4097437 <https://reviews.llvm.org/D142224#4097437>, @aganea wrote:

> Sorry for the spam. Test coverage would be welcome too :-) The following should exercise the crash: `RUN: llvm-readobj --help | head -c1`

Yes, I did consider adding something like this as a simple test but it does kind of assume that `llvm-readobj --help` is using `raw_ostream`. But if you think it has value then I'll add it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142224/new/

https://reviews.llvm.org/D142224