[PATCH] D143159: [SanitizerBinaryMetadata] Treat constant globals and non-escaping addresses specially

Marco Elver via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 02:33:34 PST 2023


melver created this revision.
melver added a reviewer: dvyukov.
Herald added subscribers: Enna1, hiraditya.
Herald added a project: All.
melver requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

For atomics metadata, we can make data race analysis more efficient by:

1. Pretending const global accesses are atomic -- there should only be reads to such data (however, const_casts violate this assumption - marking the access as "atomic" means it'll still be analyzed, but can be done at lower cost if "atomic" races are not to be reported).
2. Ignoring "pure" functions that include memory accesses but which only access non-escaping (non-shared) addresses.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D143159

Files:
  llvm/lib/Transforms/Instrumentation/SanitizerBinaryMetadata.cpp
  llvm/test/Instrumentation/SanitizerBinaryMetadata/pretend-atomic-access.ll
  llvm/test/Instrumentation/SanitizerBinaryMetadata/shared-address.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143159.494220.patch
Type: text/x-patch
Size: 10889 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230202/cc7022dc/attachment.bin>


More information about the llvm-commits mailing list