[PATCH] D141891: [VP][DAGCombiner] Introduce generalized pattern match for vp sdnodes.

[Yeting Kuo via Phabricator via llvm-commits]

fakepaper56 added inline comments.


================
Comment at: llvm/include/llvm/IR/VPIntrinsics.def:111
+// \p SDOPC      The opcode of the instruction with the same function.
+#ifndef VP_PROPERTY_FUNCTIONAL_SDOPC
+#define VP_PROPERTY_FUNCTIONAL_SDOPC(SDOPC)
----------------
craig.topper wrote:
> And this?
`VP_PROPERTY_FUNCTIONAL_INTRINSIC` also uses "FUNCTIONAL", so I am preferred to use my original naming here for consistency now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141891/new/

https://reviews.llvm.org/D141891