[PATCH] D142888: [compiler-rt] Fix building GWPASAN on ARM

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/CMakeLists.txt:57-59
+    list(APPEND SCUDO_LINK_LIBS "$<TARGET_LINKER_FILE:unwind_static>" dl)
+  elseif(LIBUNWIND_ENABLE_SHARED)
+    list(APPEND SCUDO_LINK_LIBS "$<TARGET_LINKER_FILE:unwind_shared>")
----------------
This could be a single generator expression, see https://github.com/llvm/llvm-project/blob/4f4b2161ec3cc42890aa9a445588d5a9a67e9033/compiler-rt/CMakeLists.txt#L596. I'm also not sure if we should prefer static over shared library.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142888/new/

https://reviews.llvm.org/D142888