[PATCH] D142084: [X86][MemFold] Upgrade the mechanism of auto-generated Memory Folding Table

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 22:37:38 PST 2023


skan added inline comments.


================
Comment at: llvm/utils/TableGen/X86FoldTablesEmitterManualMapSet.inc:1
+// For manually mapping instructions that do not match by their encoding.
+const ManualMapEntry ManualMapSet[] = {
----------------
This comment does not applies to all the entries in the table, I think we should move it to a suitable place. in this file.
And we need a clarification for each group in this table.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142084/new/

https://reviews.llvm.org/D142084



More information about the llvm-commits mailing list