[PATCH] D142949: [lld] Destroy CommonLinkerContext inside lld::*::link after D108850

Wed Feb 1 22:28:03 PST 2023

MaskRay added a comment.

In D142949#4094729 <https://reviews.llvm.org/D142949#4094729>, @aganea wrote:

> In D142949#4094414 <https://reviews.llvm.org/D142949#4094414>, @MaskRay wrote:
>
>> Do you happen to have more information about which specific line may trigger a problem on Windows? Does this patch regress it?
>
> The previous issue was caused by this call <https://github.com/llvm/llvm-project/blob/main/lld/ELF/InputFiles.cpp#L507> to `fatal` but you fixed it in rGd9dbf9e30a581fcadd667b6d8e5827a4003b85a2 <https://reviews.llvm.org/rGd9dbf9e30a581fcadd667b6d8e5827a4003b85a2>, see problem description in rG45b8a741fbbf <https://reviews.llvm.org/rG45b8a741fbbf271e0fb71294cb7cdce3ad4b9bf3>.
> My whole point is that we don't need this current patch, users can just call `lld::safeLldMain()`.

How is `auto *ctx = new CommonLinkerContext` (with a later cleanup) different from an on-stack `COFFLinkerContext ctx;` whose destructor is not called?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142949/new/

https://reviews.llvm.org/D142949