[PATCH] D142084: [X86][MemFold] Upgrade the mechanism of auto-generated Memory Folding Table

[Bing Yu via Phabricator via llvm-commits]

yubing added inline comments.


================
Comment at: llvm/utils/TableGen/X86FoldTablesEmitter.cpp:50
+  // Used for RegOp->MemOp conversion. Encoded as Log2(Align) + 1 to allow 0
+  // to mean align of 0.
+  // (stored in bits 8 - 11)
----------------
pengfei wrote:
> 1?
i copy the enum's definition from llvm/lib/Target/X86/X86InstrFoldTables.h


================
Comment at: llvm/utils/TableGen/X86FoldTablesEmitter.cpp:237
+    // Comparator function
+    bool operator()(const CodeGenInstruction *LHS,
+                    const CodeGenInstruction *RHS) const {
----------------
pengfei wrote:
> Should be a space here.
clang-format can't do this. i observed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142084/new/

https://reviews.llvm.org/D142084